Skip to content

fix: native splash 제거#148

Merged
surfwithus merged 1 commit intomainfrom
fix/splash
Aug 18, 2025
Merged

fix: native splash 제거#148
surfwithus merged 1 commit intomainfrom
fix/splash

Conversation

@surfwithus
Copy link
Collaborator

@surfwithus surfwithus commented Aug 18, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • 스타일
    • Android: 시작 화면을 단색(흰색)으로 단순화했습니다. 야간 모드 전용 배경을 제거하여 모든 테마에서 일관된 흰색 배경이 표시됩니다.
    • iOS: Launch Screen의 이미지 요소를 제거하고 단색(흰색) 배경만 표시하도록 변경했습니다.
    • 사용자 영향: 앱 실행 시 로고/이미지 없이 깔끔한 흰색 시작 화면이 노출되며, 다크 모드에서도 동일한 화면이 유지됩니다.

@coderabbitai
Copy link

coderabbitai bot commented Aug 18, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

Android과 iOS에서 스플래시 관련 리소스를 제거하고, 런치 화면 배경을 단색 흰색으로 단순화했다. Android는 launch_background 관련 drawable들을 삭제하고 LaunchTheme의 windowBackground를 흰색으로 변경했다. iOS는 LaunchScreen.storyboard에서 이미지 및 제약을 제거해 흰 배경만 남겼다.

Changes

Cohort / File(s) Change Summary
Android Drawable 제거
frontend/ongi/android/app/src/main/res/drawable-night-v21/launch_background.xml, frontend/ongi/android/app/src/main/res/drawable-night/launch_background.xml, frontend/ongi/android/app/src/main/res/drawable-v21/launch_background.xml		 launch_background 레이어 리스트 drawable 3종 삭제(배경/스플래시 비트맵 포함).
Android 스타일 단순화
frontend/ongi/android/app/src/main/res/values/styles.xml, frontend/ongi/android/app/src/main/res/values-night/styles.xml		 LaunchTheme에서 여러 윈도우 속성 제거 후 android:windowBackground를 @android:color/white로 설정.
iOS 런치 스크린 정리
frontend/ongi/ios/Runner/Base.lproj/LaunchScreen.storyboard		 LaunchBackground/LaunchImage 이미지 뷰 및 관련 제약 삭제, 리소스 참조 제거. 흰 배경만 남김.

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant OS
  participant App

  User->>OS: 앱 실행
  OS->>App: 런치 화면 요청
  App-->>OS: 런치 설정(단색 흰색 배경)
  OS-->>User: 흰색 런치 화면 표시
  OS->>App: 앱 초기화 완료 후 전환
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

귀가 쫑긋 토끼 개발자, 붓은 살짝 쉿—
번쩍이던 스플래시는 가고, 흰 새벽만 남았네.
비트맵은 풀밭에 놓고, 제약도 훌쩍 넘어서—
안드로이드, iOS, 한결같이 담백하게.
탭 한 번에, 깔끔한 시작! 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Free

💡 Knowledge Base configuration:

  • Jira integration is disabled
  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 6965caf and ac40172.

📒 Files selected for processing (6)
  • frontend/ongi/android/app/src/main/res/drawable-night-v21/launch_background.xml (0 hunks)
  • frontend/ongi/android/app/src/main/res/drawable-night/launch_background.xml (0 hunks)
  • frontend/ongi/android/app/src/main/res/drawable-v21/launch_background.xml (0 hunks)
  • frontend/ongi/android/app/src/main/res/values-night/styles.xml (1 hunks)
  • frontend/ongi/android/app/src/main/res/values/styles.xml (1 hunks)
  • frontend/ongi/ios/Runner/Base.lproj/LaunchScreen.storyboard (2 hunks)

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Join our Discord community for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@surfwithus surfwithus merged commit 38210b7 into main Aug 18, 2025
3 of 4 checks passed
@surfwithus surfwithus deleted the fix/splash branch August 18, 2025 16:50
Neibce pushed a commit to 2025-PNU-SW-Hackathon/PNUSW-2025-OnGi-10 that referenced this pull request Aug 25, 2025
@surfwithus
fix: native splash 제거 (Neibce/OnGi#148)
80abe51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@surfwithus